Skip to content

fix(ci): Cache node_modules of all packages - #127219

Merged
TkDodo merged 1 commit into
masterfrom
tkdodo/fix/workspace-node-modules-cache
Oct 13, 2026
Merged

TkDodo merged 1 commit into
masterfrom
tkdodo/fix/workspace-node-modules-cache

Conversation

@TkDodo

@TkDodo TkDodo commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Our CI cache task needs to store all node_modules of all packages to properly restore them, and the cache key needs to know about runner.arch, as we have different architectures apparently which means some optional peerDeps might be missing in an install.

Cache root and workspace node_modules with bounded globs to avoid pnpm symlink archive conflicts.
Include runner architecture, workspace settings, and the root package manifest in cache keys.
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 13, 2026
@TkDodo TkDodo changed the title fix(ci): Cache workspace dependencies by runner architecture fix(ci): Cache node_modules of all packages Oct 13, 2026
@TkDodo
TkDodo marked this pull request as ready for review October 13, 2026 08:18
@TkDodo
TkDodo requested a review from a team as a code owner October 13, 2026 08:18
@TkDodo
TkDodo requested a review from a team October 13, 2026 08:18
@TkDodo
TkDodo merged commit 91c1592 into master Oct 13, 2026
75 checks passed
@TkDodo
TkDodo deleted the tkdodo/fix/workspace-node-modules-cache branch October 13, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants